Skip to content
Published on

Code Review English: Constructive Feedback Conversations That Build Better Code

🇰🇷KO🇺🇸EN🇯🇵JA
Authors
  • Name
    Twitter
Code Review Feedback Cover

1. 🎙️ 팟캐스트 인트로

Welcome back to your practical English output training. Today’s theme is giving constructive feedback in code reviews without sounding rude or vague. You’ll train phrases for pointing out issues, suggesting improvements, and agreeing on next actions. Stay sharp, speak clearly, and let’s build feedback English you can use in real team conversations.

2. 📝 핵심 표현 5개

ExpressionMeaning (KR)Example
I noticed that ~~를 발견했어요(관찰 기반 피드백)I noticed that this function handles errors differently from the other modules.
Could we consider ~?~을 고려해볼 수 있을까요?Could we consider splitting this logic into smaller functions?
One concern is that ~한 가지 우려는 ~입니다One concern is that this query may be slow on large datasets.
To make it clearer, we could ~더 명확하게 하려면 ~할 수 있어요To make it clearer, we could rename this variable to userProfileMap.
Does this approach work for you?이 접근 괜찮나요?I suggest adding input validation first—does this approach work for you?

3. 🔇 빈칸 채우기 — 5문제

  1. I __ that this API returns different error codes depending on the endpoint.
    정답: noticed

  2. Could we __ moving this helper function to a shared utility file?
    정답: consider

  3. One __ is that this loop runs on every request and may affect performance.
    정답: concern

  4. To make it __, we could add a short comment above this condition.
    정답: clearer

  5. I can open a PR for this refactor—does this approach __ for you?
    정답: work

4. 🗣️ 말하기 연습 — 3문제

  1. 상황: 동료 코드에서 중복 로직을 발견했다. 정중하게 개선 제안하기.
    모범 답안: I noticed we have similar logic in two places. Could we consider extracting it into one reusable function?

  2. 상황: 성능 저하가 우려되는 쿼리를 발견했다. 팀원 기분 상하지 않게 말하기.
    모범 답안: One concern is that this query might become expensive with larger data. Could we consider adding an index before release?

  3. 상황: 피드백 후 실행 계획까지 맞추고 싶다.
    모범 답안: To make it clearer, we could update the naming and add tests. Does this approach work for you?

5. 🔄 한→영 번역 퀴즈 — 3문제

  1. “이 부분은 의도는 좋은데, 변수 이름이 조금 모호해요.”
    정답: This part has a good intention, but the variable name is a bit ambiguous.

  2. “이 로직을 함수로 분리하는 것을 고려해볼 수 있을까요?”
    정답: Could we consider separating this logic into a function?

  3. “배포 전에 테스트 케이스를 하나 더 추가하면 더 안전할 것 같아요.”
    정답: I think it would be safer if we add one more test case before deployment.

6. 👂 리스닝 챌린지

아래 문장을 듣고 빈칸을 채우세요.

A) “I __ that this endpoint does not validate empty input.”
정답: noticed

B) “One __ is that this change may break backward compatibility.”
정답: concern

C) “To make it clearer, we could add examples in the README. __ this approach work for you?”
정답: Does

Discuss on Twitter • View on GitHub