Skip to content
Published on

Code Review English: Constructive Feedback Conversations That Build Better Code

🇰🇷KO🇺🇸EN🇯🇵JA
Authors
  • Name
    Twitter
Code Review Feedback Cover

1. 🎙️ Podcastイントロ

Welcome back to your practical English output training. Today’s theme is giving constructive feedback in code reviews without sounding rude or vague. You’ll tr​​ain phrases for pointing out issues, suggesting improvements, and agreeing on next actions. Stay sharp, speak clearly, and let’s build feedback English you can use in real team conversations.

2. 📝 コア表現5個

ExpressionMeaning（JP）例
I noticed that ~~を見つけました（観察ベースのフィードバック）I noticed that this function handles errors differently from the other modules.
Could we consider ~?〜を考えてみましょうか？Could we consider splitting this logic into smaller functions?
One concern is that ~一つの懸念は〜ですOne concern is that this query may be slow on large datasets.
To make it clearer, we could ~より明確にするには〜できますTo make it clearer, we could rename this variable to userProfileMap.
Does this approach work for you?このアプローチは大丈夫ですか？I suggest adding input validation first—does this approach work for you?

3. 🔇 空白を埋める — 5問題

  1. I __ that this API returns different error codes depending on the endpoint.
    正解: noticed

  2. Could we __ moving this helper function to a shared utility file?
    正解：consider

  3. One __ is that this loop runs on every request and may affect performance.
    正解: concern

  4. To make it __, we could add a short comment above this condition.
    正解：clearer

  5. I can open a PR for this refactor—does this approach __ for you?
    正解: work

4. 🗣️ 話す練習 — 3問題

1.状況：同僚コードで冗長ロジックが見つかりました。丁寧に改善を提案する。
模範解答: I noticed we have similar logic in two places. Could we consider extracting it into one reusable function?

2.状況：パフォーマンスの低下が懸念されるクエリを発見しました。チームメンバー気分が悪くないように言う。
模範解答: One concern is that this this query might become expensive with larger data. Could we consider adding an index before release?

  1. 状況: フィードバック後、実行計画まで合わせたい。
    模範解答: To make it clearer, we could update the naming and add tests. Does this approach work for you?

5. 🔄 韓→英翻訳クイズ — 3問題

  1. 「この部分は意図は良いのですが、変数名が少し曖昧です」
    正解: This part has a good intention, but the variable name is a bit ambiguous.

  2. 「このロジックを関数に分割することを考えてみましょうか？」
    正解: Could we consider separating this logic into a function?

  3. 「配布前にもう1つのテストケースを追加すると、より安全になると思います」
    正解: I think it would be safer if we add one more test case before deployment.

6. リスニングチャレンジ

以下の文を聞いて空白を記入してください。

A) “I __ that this endpoint does not validate empty input.”
正解: noticed

B) 「One __ is that this change may break backward compatibility.」
正解: concern

C) “To make it clearer, we could add examples in the README. __ this approach work for you?”
正解: Does

Discuss on Twitter • View on GitHub